-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: chore(workbenches): bring in the rhel9 rstudio workbench and docs release notes for easier maintenance in single repository #982
Conversation
…wnstream Update runtime images with e1aee40 build commit
…stream Incorporate updates for digest updater workflow on downstream as well
Update cuda layer for RHEL, to 12.1
…ream Revert nginx version to 1.22 since 1.24 is not available on RHEL yet
sync main branch with opendatahub main branch
…estream-downstream Update ImageSteam for Habana 1.13
- Fix the typo in the datascience notebook Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Remove the intel based image from the overlay as its ODH only
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Fix the runtime updater github action
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Fix the runtime updater github action branch 2024a
…st-updater-8577545330 [Digest Updater Action] Update Runtime Images
…st-updater-8581586298 [Digest Updater Action] Update Notebook Images
[ main] sync main branch with upstream main branch
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, we need to be sure we won't propagate this file into the odh build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to be sure this won't end in the odh build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not? it's just a build recipe, no problem having it in ODH
some odh users have red hat subscription, such as the no-cost developer subscription offering, and they can build the rstudio image for themselves perfectly legally
Soo, I'm not fully sure about the way we're introducing it here including the whole files history (so many commits here), but I'm not gonna insist on changing it as per the offline discussion this was the intention. In general, I'm okay with this as it will make our life slightly easier as we can catch eventual issues with rstudio earlier in the process instead of caching things on the very last time during the RHOAI builds. Truth is that it has the disadvantage we're bringing quite a number of files and source code to the odh repository where these aren't used in the resulting ODH release in any way in the end. |
I have a hard time to investigate root cause of these konflux failures... Software versions is expected as this would need to be rebased to mittigate it first. |
The enterprise contract? I already addressed that in #982 (comment) It's some complete nonsense that's actually not related to rstudio image. I am hoping it will go away when a -push pipeline runs with all the images. Tried a rerun of the PR and it's still there. |
/retest rstudio-rhel9-python-3-11-on-pull-request |
/override validation-of-sw-versions-in-imagestreams |
@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override cuda-rstudio-rhel9-python-3-11 |
@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I did get sufficient amount of informal lgtm after publicizing this within team, to just go ahead and not drag this endlessly, I feel /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest rstudio-rhel9-python-3-11-on-pull-request |
/retest cuda-rstudio-rhel9-python-3-11-on-pull-request |
Opened support ticket about slow clamav-build |
/override ci/prow/images
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
d775879
into
opendatahub-io:main
…_rstudio___ NO-JIRA: chore(workbenches): bring in the rhel9 rstudio workbench and docs release notes for easier maintenance in single repository
Description
Failing Konflux Enterprise Contract is hopefully caused by the tekton pipelines only existing in PR and not in the repo itself. Hopefully after the component is onboarded and settles in, this will go away.
How Has This Been Tested?
Konflux
Need to add pull-secret and Red Hat subscription.
pull secret
https://access.redhat.com/terms-based-registry/token/rhoai-ide-konflux
subscription
I am using the deprecated way because it's the same way that GitHub Actions are using
Merge criteria: