Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: chore(workbenches): bring in the rhel9 rstudio workbench and docs release notes for easier maintenance in single repository #982

Merged

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Mar 21, 2025

Description

Failing Konflux Enterprise Contract is hopefully caused by the tekton pipelines only existing in PR and not in the repo itself. Hopefully after the component is onboarded and settles in, this will go away.

How Has This Been Tested?

base64 < ~/Downloads/git-crypt-key | gh secret set GIT_CRYPT_KEY --repo opendatahub-io/notebooks
✓ Set Actions secret GIT_CRYPT_KEY for opendatahub-io/notebooks

Konflux

[1/3] STEP 1/8: FROM registry.redhat.io/rhel9/python-311:latest AS base
Trying to pull registry.redhat.io/rhel9/python-311:latest...
Error: creating build container: initializing source docker://registry.redhat.io/rhel9/python-311:latest: unable to retrieve auth token: invalid username/password: unauthorized: Please login to the Red Hat Registry using your Customer Portal credentials. Further instructions can be found here: https://access.redhat.com/RegistryAuthentication

Need to add pull-secret and Red Hat subscription.

pull secret

https://access.redhat.com/terms-based-registry/token/rhoai-ide-konflux

subscription

I am using the deprecated way because it's the same way that GitHub Actions are using

oc create secret generic etc-pki-entitlement -n rhoai-ide-konflux-tenant \
    --from-file ci/secrets/run/secrets/etc-pki-entitlement/1358292728734056503.pem \
    --from-file ci/secrets/run/secrets/etc-pki-entitlement/1358292728734056503-key.pem

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Sorry, something went wrong.

harshad16 and others added 30 commits March 19, 2024 12:09
…wnstream

Update runtime images with e1aee40 build commit
…stream

Incorporate updates for digest updater workflow on downstream as well
…ream

Revert nginx version to 1.22 since 1.24 is not available on RHEL yet
sync main branch with opendatahub main branch
…estream-downstream

Update ImageSteam for Habana 1.13
- Fix the typo in the datascience notebook

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Remove the intel based image from the overlay as its ODH only
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Fix the runtime updater github action branch 2024a
…st-updater-8577545330

[Digest Updater Action] Update Runtime Images
…st-updater-8581586298

[Digest Updater Action] Update Notebook Images
[ main] sync main branch with upstream main branch
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels Mar 21, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, we need to be sure we won't propagate this file into the odh build

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to be sure this won't end in the odh build

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not? it's just a build recipe, no problem having it in ODH

some odh users have red hat subscription, such as the no-cost developer subscription offering, and they can build the rstudio image for themselves perfectly legally

@jstourac
Copy link
Member

Soo, I'm not fully sure about the way we're introducing it here including the whole files history (so many commits here), but I'm not gonna insist on changing it as per the offline discussion this was the intention.

In general, I'm okay with this as it will make our life slightly easier as we can catch eventual issues with rstudio earlier in the process instead of caching things on the very last time during the RHOAI builds. Truth is that it has the disadvantage we're bringing quite a number of files and source code to the odh repository where these aren't used in the resulting ODH release in any way in the end.

@jstourac
Copy link
Member

I have a hard time to investigate root cause of these konflux failures...

Software versions is expected as this would need to be rebased to mittigate it first.

@jiridanek
Copy link
Member Author

I have a hard time to investigate root cause of these konflux failures...

The enterprise contract? I already addressed that in #982 (comment)

It's some complete nonsense that's actually not related to rstudio image. I am hoping it will go away when a -push pipeline runs with all the images. Tried a rerun of the PR and it's still there.

@jiridanek
Copy link
Member Author

/retest rstudio-rhel9-python-3-11-on-pull-request
abusing the pr to check if konflux is broken or not

@opendatahub-io opendatahub-io deleted a comment from openshift-ci bot Mar 24, 2025
@jiridanek
Copy link
Member Author

/override validation-of-sw-versions-in-imagestreams

Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • validation-of-sw-versions-in-imagestreams

Only the following failed contexts/checkruns were expected:

  • build
  • ci/prow/images
  • pull-ci-opendatahub-io-notebooks-2023a-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override validation-of-sw-versions-in-imagestreams

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/override cuda-rstudio-rhel9-python-3-11

Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • cuda-rstudio-rhel9-python-3-11

Only the following failed contexts/checkruns were expected:

  • build
  • ci/prow/images
  • pull-ci-opendatahub-io-notebooks-2023a-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override cuda-rstudio-rhel9-python-3-11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

I did get sufficient amount of informal lgtm after publicizing this within team, to just go ahead and not drag this endlessly, I feel

/approve

Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member Author

/retest rstudio-rhel9-python-3-11-on-pull-request

@jiridanek
Copy link
Member Author

/retest cuda-rstudio-rhel9-python-3-11-on-pull-request

@opendatahub-io opendatahub-io deleted a comment from openshift-ci bot Mar 25, 2025
@opendatahub-io opendatahub-io deleted a comment from openshift-ci bot Mar 25, 2025
@jiridanek
Copy link
Member Author

Opened support ticket about slow clamav-build

@jiridanek
Copy link
Member Author

jiridanek commented Mar 25, 2025

/override ci/prow/images
Infra issue

Errors during downloading metadata for repository 'packages-microsoft-com-prod':
  - Curl error (7): Couldn't connect to server for https://packages.microsoft.com/rhel/9.0/prod/repodata/repomd.xml [Failed to connect to packages.microsoft.com port 443: Connection refused]
Error: Failed to download metadata for repo 'packages-microsoft-com-prod': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried
error: build error: building at STEP "RUN ACCEPT_EULA=Y dnf install -y mssql-tools18 unixODBC-devel && dnf clean all && rm -rf /var/cache/yum": while running runtime: exit status 1

Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images
Infra issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d775879 into opendatahub-io:main Mar 25, 2025
16 of 17 checks passed
@jiridanek jiridanek deleted the jd_merge_in_rhds_rstudio___ branch March 25, 2025 19:03
jiridanek pushed a commit to rhoai-ide-konflux/notebooks that referenced this pull request Mar 30, 2025
…_rstudio___

NO-JIRA: chore(workbenches): bring in the rhel9 rstudio workbench and docs release notes for easier maintenance in single repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants