Skip to content

OCPBUGS-54263: IBMCloud: Move to IBM TF openshift fork #9604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2025
Merged

OCPBUGS-54263: IBMCloud: Move to IBM TF openshift fork #9604

merged 1 commit into from
Mar 29, 2025
+29 −11

Conversation

cjschaef
Copy link
Member

Use the openshift org fork of IBM Cloud Terraform provider to pick up the fix for CIS API changes. This bump cannot be directly backported due to golang version requirements by the TF provider.

Related: https://issues.redhat.com/browse/OCPBUGS-54263
Related: https://issues.redhat.com/browse/OCPBUGS-53258

@cjschaef
OCPBUGS-54263: IBMCloud: Move to IBM TF openshift fork
Loading
Loading status checks…
8c31350 
Use the openshift org fork of IBM Cloud Terraform provider to pick
up the fix for CIS API changes. This bump cannot be directly
backported due to golang version requirements by the TF provider.

Related: https://issues.redhat.com/browse/OCPBUGS-54263
Related: https://issues.redhat.com/browse/OCPBUGS-53258
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 26, 2025
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-54263, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-54263 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Use the openshift org fork of IBM Cloud Terraform provider to pick up the fix for CIS API changes. This bump cannot be directly backported due to golang version requirements by the TF provider.

Related: https://issues.redhat.com/browse/OCPBUGS-54263
Related: https://issues.redhat.com/browse/OCPBUGS-53258

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 26, 2025
@cjschaef
Copy link
Member Author

/retest

@cjschaef
Copy link
Member Author

This PR is independent from the 4.17 PR, which is not yet open as it will cherry-pick from 4.18 (changes are different due to golang version dependencies), and is not blocked by 4.17/4.18 changes, as that will not be directly cherry-picked into 4.16. Until 4.18 and then 4.17 merges however, the Jira reference will not be happy, if that is mandatory for this PR.

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Mar 27, 2025

pre-merge test with release-4.16@145d7e76, merging: #9604 8c31350 IPI public install PASS

@cjschaef
Copy link
Member Author

/test e2e-ibmcloud-ovn e2e-powervs-ovn

@petr-balogh petr-balogh mentioned this pull request Mar 28, 2025
Closed
@sdodson sdodson added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 29, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Mar 29, 2025

/test e2e-ibmcloud-ovn

@sdodson
Copy link
Member

sdodson commented Mar 29, 2025

/override ci/prow/shellcheck ci/prow/tf-lint

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 29, 2025

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/shellcheck, ci/prow/tf-lint

In response to this:

/override ci/prow/shellcheck ci/prow/tf-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sdodson
Copy link
Member

sdodson commented Mar 29, 2025

/override ci/prow/yaml-lint

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 29, 2025

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/yaml-lint

In response to this:

/override ci/prow/yaml-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bc7dda2 and 2 for PR HEAD 8c31350 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 29, 2025

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-vsphere-ovn 8c31350 link false /test okd-scos-e2e-vsphere-ovn
ci/prow/e2e-ibmcloud-ovn 8c31350 link false /test e2e-ibmcloud-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 22009ee into openshift:release-4.16 Mar 29, 2025
16 of 19 checks passed
@openshift-ci-robot
Copy link
Contributor

@cjschaef: Jira Issue OCPBUGS-54263: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-54263 has been moved to the MODIFIED state.

In response to this:

Use the openshift org fork of IBM Cloud Terraform provider to pick up the fix for CIS API changes. This bump cannot be directly backported due to golang version requirements by the TF provider.

Related: https://issues.redhat.com/browse/OCPBUGS-54263
Related: https://issues.redhat.com/browse/OCPBUGS-53258

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.16.0-202503290705.p0.g22009ee.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.16.0-202503290705.p0.g22009ee.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.16.0-202503290705.p0.g22009ee.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.16.0-202503290705.p0.g22009ee.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2025-03-29-134339

@cjschaef cjschaef deleted the ocpbugs-54263 branch March 31, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andfasano andfasano

@patrickdillon patrickdillon

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cjschaef @openshift-ci-robot @MayXuQQ @sdodson @openshift-bot @openshift-merge-robot