OCPBUGS-42241: Update to cluster-api-provider-azure release-v1.17.5 #9596
Conversation
openshift-merge-robot
added
the
needs-rebase
sadasu
force-pushed
the
update-capz-version
branch
from
b8cf675 to
8b183cd
Compare
openshift-merge-robot
removed
the
needs-rebase
sadasu
force-pushed
the
update-capz-version
branch
from
8b183cd to
f1d2496
Compare
sadasu
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@sadasu: This pull request references Jira Issue OCPBUGS-42241, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@sadasu: This pull request references Jira Issue OCPBUGS-42241, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -735,9 +735,6 @@ spec: | |||
| description: |- | |||
| ResourceID is the Azure resource ID for the User Assigned MSI resource. | |||
| Only applicable when type is UserAssignedMSI. | |||
|
|
|||
There was a problem hiding this comment.
Hmm, not sure if I am missing something but I tried 2 ways to get the infra manifest:
- Download from official release assets: https://github.com/kubernetes-sigs/cluster-api-provider-azure/releases/tag/v1.17.5
- Clone CAPZ repo and checkout tag v1.17.5 + run
make release-manifests.
Both produced the same content but different from the one committed here. Maybe, this infra manifest should be updated?
There was a problem hiding this comment.
Did this again and found a different version from what I had earlier. Please take a look again and confirm.
There was a problem hiding this comment.
Clone CAPZ repo and checkout tag v1.17.5 + run make release-manifests.
Actually, I have to run make release to get the right infra manifest (i.e. setting correct controller image tag). But in any case, the manifest here looks good!
This will bring in the fix: kubernetes-sigs/cluster-api-provider-azure#5497
Update CAPI azure's infrastructure manifest accompanying the version bump.
sadasu
force-pushed
the
update-capz-version
branch
from
f1d2496 to
0fe9c47
Compare
|
@sadasu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
sadasu
changed the title
|
/retest-required |
|
#9603 fixes the shared vpc test failure |
|
/approve Structuring the commits like this (go.mod in one commit) makes it much easier to review. Nice. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@sadasu: This pull request references Jira Issue OCPBUGS-42241, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/override ci/prow/okd-scos-images |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-scos-images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 0cb08d1
into
openshift:main
|
@sadasu: Jira Issue OCPBUGS-42241: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-42241 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
Update cluster-api-provider-azure to release-1.17.5 to bring in the fix kubernetes-sigs/cluster-api-provider-azure#5497