Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-53258: IBMCloud: Bump TF provider for CIS fix #9589

Merged
merged 1 commit into from
Mar 28, 2025
Merged

OCPBUGS-53258: IBMCloud: Bump TF provider for CIS fix #9589

merged 1 commit into from
Mar 28, 2025

Conversation

cjschaef
Copy link
Member

Bump the IBM Cloud Terraform provider to pick up the fix for CIS API changes. This bump cannot be directly backported due to golang version requirements by the TF provider.

Related: https://issues.redhat.com/browse/OCPBUGS-53258

@cjschaef
OCPBUGS-53258: IBMCloud: Bump TF provider for CIS fix
5b593b8 
Bump the IBM Cloud Terraform provider to pick up the fix
for CIS API changes. This bump cannot be directly backported
due to golang version requirements by the TF provider.

Related: https://issues.redhat.com/browse/OCPBUGS-53258
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 20, 2025
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-53258, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bump the IBM Cloud Terraform provider to pick up the fix for CIS API changes. This bump cannot be directly backported due to golang version requirements by the TF provider.

Related: https://issues.redhat.com/browse/OCPBUGS-53258

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cjschaef
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 21, 2025
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-53258, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @MayXuQQ

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from MayXuQQ March 21, 2025 03:36
@cjschaef
Copy link
Member Author

/retest

MayXuQQ
MayXuQQ approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@MayXuQQ MayXuQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-merge test IPI install PASS

@cjschaef
Copy link
Member Author

/backport release-4.18

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Mar 21, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 21, 2025
@cjschaef
Copy link
Member Author

e2e-ibmcloud-ovn only failure was

: Run multi-stage test e2e-ibmcloud-ovn - e2e-ibmcloud-ovn-gather-ibmcloud-resource container test

Should be resolved as part of openshift/release#62997

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Mar 26, 2025

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 26, 2025 •
edited
Loading

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 5b593b8 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-ibmcloud-ovn 5b593b8 link false /test e2e-ibmcloud-ovn
ci/prow/e2e-azure-ovn-resourcegroup 5b593b8 link false /test e2e-azure-ovn-resourcegroup

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Mar 28, 2025

/retest-required

@petr-balogh petr-balogh mentioned this pull request Mar 28, 2025
Closed
@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MayXuQQ, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025
@patrickdillon
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 28, 2025
@patrickdillon
Copy link
Contributor

/skip

1 similar comment
@patrickdillon
Copy link
Contributor

/skip

@sdodson
Copy link
Member

sdodson commented Mar 28, 2025

/override ci/prow/e2e-gcp-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit fbf0b65 into openshift:main Mar 28, 2025
38 checks passed
@openshift-ci-robot
Copy link
Contributor

@cjschaef: Jira Issue OCPBUGS-53258: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-53258 has been moved to the MODIFIED state.

In response to this:

Bump the IBM Cloud Terraform provider to pick up the fix for CIS API changes. This bump cannot be directly backported due to golang version requirements by the TF provider.

Related: https://issues.redhat.com/browse/OCPBUGS-53258

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cjschaef cjschaef deleted the ocpbugs-53258 branch March 28, 2025 17:57
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.19.0-202503281910.p0.gfbf0b65.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.19.0-202503281910.p0.gfbf0b65.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.19.0-202503281910.p0.gfbf0b65.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.20.0-202503281911.p0.gfbf0b65.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MayXuQQ MayXuQQ

@pawanpinjarkar pawanpinjarkar

@rna-afk rna-afk

Assignees

@patrickdillon patrickdillon

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cjschaef @openshift-ci-robot @MayXuQQ @patrickdillon @sdodson @openshift-bot