Skip to content

OCPBUGS-52191: [release-4.16] capi/aws: bump provider for LB DNS lookup fix #9547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2025
Merged

OCPBUGS-52191: [release-4.16] capi/aws: bump provider for LB DNS lookup fix #9547

merged 3 commits into from
Mar 19, 2025
+251 −126

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Mar 7, 2025

This bumps CAPA to version that has the fix for the LB DNS name lookup issue.

Manual backport for #8927.

tthvo added 3 commits March 7, 2025 11:55
@tthvo
OCPBUGS-52191: bump aws provider version to 2361956824d0
Loading
Loading status checks…
f0abc95 
This bumps CAPA to version that has the fix for the LB DNS name lookup issue.
@tthvo
crd: regenerate provider CRD after vendor bump
eb9ac9d
@tthvo
vendor: go mod vendor
536a03d
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 7, 2025
@openshift-ci-robot
Copy link
Contributor

@tthvo: This pull request references Jira Issue OCPBUGS-52191, which is invalid:

  • expected the bug to target the "4.16.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-52191 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This bumps CAPA to version that has the fix for the LB DNS name lookup issue.

Manual backport for #8927.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from r4f4 and rna-afk March 7, 2025 20:03
@tthvo
Copy link
Member Author

tthvo commented Mar 7, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@tthvo: This pull request references Jira Issue OCPBUGS-52191, which is invalid:

  • expected Jira Issue OCPBUGS-52191 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo
Copy link
Member Author

tthvo commented Mar 7, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@tthvo: This pull request references Jira Issue OCPBUGS-52191, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo
Copy link
Member Author

tthvo commented Mar 7, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 7, 2025
@openshift-ci-robot
Copy link
Contributor

@tthvo: This pull request references Jira Issue OCPBUGS-52191, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-44231 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-44231 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 7, 2025
@openshift-ci openshift-ci bot requested a review from gpei March 7, 2025 20:11
@tthvo
Copy link
Member Author

tthvo commented Mar 7, 2025

/cc @patrickdillon

@openshift-ci openshift-ci bot requested a review from patrickdillon March 7, 2025 20:11
r4f4
r4f4 reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2025
@patrickdillon
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2025
@tthvo
Copy link
Member Author

tthvo commented Mar 8, 2025

/retest-required

@patrickdillon
Copy link
Contributor

/label backport-risk-assessed
/skip
/retest-required

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 10, 2025
@tthvo
Copy link
Member Author

tthvo commented Mar 10, 2025

/cc @yunjiang29
/retest

@openshift-ci openshift-ci bot requested a review from yunjiang29 March 10, 2025 18:33
@gpei
Copy link
Contributor

gpei commented Mar 11, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 11, 2025
@patrickdillon
Copy link
Contributor

/retest-required

1 similar comment
@tthvo
Copy link
Member Author

tthvo commented Mar 14, 2025

/retest-required

@patrickdillon
Copy link
Contributor

/override ci/prow/shellcheck
/override ci/prow/tf-lint
/override ci/prow/yaml-lint

@tthvo
Copy link
Member Author

tthvo commented Mar 17, 2025

/skip

@tthvo
Copy link
Member Author

tthvo commented Mar 17, 2025

/override ci/prow/shellcheck
/skip

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

@tthvo: tthvo unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override ci/prow/shellcheck
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@patrickdillon
Copy link
Contributor

/override ci/prow/shellcheck
/override ci/prow/tf-lint
/override ci/prow/yaml-lint

@tthvo
Copy link
Member Author

tthvo commented Mar 18, 2025

/retest-required

2 similar comments
@patrickdillon
Copy link
Contributor

/retest-required

@patrickdillon
Copy link
Contributor

/retest-required

@patrickdillon
Copy link
Contributor

/override ci/prow/shellcheck
/override ci/prow/tf-lint
/override ci/prow/yaml-lint

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/shellcheck, ci/prow/tf-lint, ci/prow/yaml-lint

In response to this:

/override ci/prow/shellcheck
/override ci/prow/tf-lint
/override ci/prow/yaml-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

@tthvo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-vsphere-ovn 536a03d link false /test okd-scos-e2e-vsphere-ovn
ci/prow/images 536a03d link unknown /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2be94b9 and 2 for PR HEAD 536a03d in total

@patrickdillon
Copy link
Contributor

Manually merging as we are blocked with ci failure

@patrickdillon patrickdillon merged commit 145d7e7 into openshift:release-4.16 Mar 19, 2025
25 of 30 checks passed
@openshift-ci-robot
Copy link
Contributor

@tthvo: Jira Issue OCPBUGS-52191: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-52191 has been moved to the MODIFIED state.

In response to this:

This bumps CAPA to version that has the fix for the LB DNS name lookup issue.

Manual backport for #8927.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo tthvo deleted the capa-remove-lb-dns-check-4.16 branch March 19, 2025 23:58
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.16.0-202503200004.p0.g145d7e7.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.16.0-202503200004.p0.g145d7e7.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.16.0-202503200004.p0.g145d7e7.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.16.0-202503200004.p0.g145d7e7.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2025-03-20-074010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4

@rna-afk rna-afk

@gpei gpei

@patrickdillon patrickdillon

@yunjiang29 yunjiang29

Assignees

@r4f4 r4f4

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tthvo @openshift-ci-robot @patrickdillon @gpei @openshift-bot @openshift-merge-robot @r4f4