Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] OCPBUGS-51116: update resolv.conf every time on bootstrap node #9504

Open
wants to merge 2 commits into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-51116: update resolv.conf every time on bootstrap node #9504

wants to merge 2 commits into from
+35 −35

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #8430

/assign MaysaMacedo

@yatanaka-1007
OCPBUGS-32792: update resolv.conf every tiem on bootstrap
edea9fa 
Currently, /etc/resolv.conf on bootstrap node is updated only once.
Because of this, /etc/resolv.conf may be incorrect due to timing
issues. By this change, /etc/resolv.conf is updtaed at all "up",
"dhcp4-update", "dhcp6-update" events.
@yatanaka-1007
OCPBUGS-32792: update resolv.conf every tiem on bootstrap
Loading
Loading status checks…
ea1317d 
Currently, /etc/resolv.conf on bootstrap node is updated only once.
Because of this, /etc/resolv.conf may be incorrect due to timing
issues. By this change, /etc/resolv.conf is updtaed at all "up",
"dhcp4-update", "dhcp6-update", "dns-change" events.

"dns-change" event is supposed to be enough if it works, but
"dns-change" is a new function[1] of NetworkManager. Other events,
"up", "dhcp4-update" and "dhcp6-update", are kept for environments
where "dns-change" doesn't works.

[1] NetworkManager starting from 1.42.2-12.el9_2 and
1.36.0-17.el8_6 adds a new event `dns-change` which is fired
whenever a change to the DNS configuration happens.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 20, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-32792 has been cloned as Jira Issue OCPBUGS-51116. Will retitle bug to link to clone.
/retitle [release-4.17] OCPBUGS-51116: update resolv.conf every time on bootstrap node

In response to this:

This is an automated cherry-pick of #8430

/assign MaysaMacedo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.17] OCPBUGS-32792: update resolv.conf every time on bootstrap node [release-4.17] OCPBUGS-51116: update resolv.conf every time on bootstrap node Feb 20, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 20, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-51116, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-32792 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-32792 to target a version in 4.18.0, but it targets "4.18" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #8430

/assign MaysaMacedo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bkhizgiy and elfosardo February 20, 2025 14:00
@MaysaMacedo
Copy link
Contributor

/cc @mkowalski

@openshift-ci openshift-ci bot requested a review from mkowalski February 20, 2025 14:47
@mkowalski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@MaysaMacedo
Copy link
Contributor

/cc @patrickdillon

@openshift-ci openshift-ci bot requested a review from patrickdillon March 3, 2025 11:24
@MaysaMacedo
Copy link
Contributor

/test e2e-openstack-dualstack
/cc @sadasu

@openshift-ci openshift-ci bot requested a review from sadasu March 13, 2025 18:30
@sadasu
Copy link
Contributor

sadasu commented Mar 14, 2025

/jira-refresh

@sadasu
Copy link
Contributor

sadasu commented Mar 14, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 14, 2025
@sadasu
Copy link
Contributor

sadasu commented Mar 14, 2025

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2025
@sadasu
Copy link
Contributor

sadasu commented Mar 14, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@sadasu: This pull request references Jira Issue OCPBUGS-51116, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-32792 to target a version in 4.18.0, 4.18.z, but it targets "4.18" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sadasu
Copy link
Contributor

sadasu commented Mar 14, 2025

@MaysaMacedo, could you please take care of the Jira errors?

@MaysaMacedo
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Jira Issue OCPBUGS-51116, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MaysaMacedo
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 18, 2025
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Jira Issue OCPBUGS-51116, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-32792 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-32792 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0, 4.18.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MaysaMacedo
Copy link
Contributor

/test e2e-openstack-dualstack

@eurijon
Copy link
Contributor

eurijon commented Mar 18, 2025

/label cherry-pick-approved

@MaysaMacedo
Copy link
Contributor

/hold

for CI to pass

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 18, 2025
@mandre
Copy link
Member

mandre commented Mar 19, 2025

/retest

@MaysaMacedo
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 69eecda and 2 for PR HEAD ea1317d in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 69eecda and 2 for PR HEAD ea1317d in total

@sadasu
Copy link
Contributor

sadasu commented Mar 26, 2025

/retest-required

@stephenfin
Copy link
Contributor

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 31, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkhizgiy bkhizgiy

@elfosardo elfosardo

@mkowalski mkowalski

@patrickdillon patrickdillon

@sadasu sadasu

Assignees

@mkowalski mkowalski

@MaysaMacedo MaysaMacedo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @openshift-ci-robot @MaysaMacedo @mkowalski @sadasu @eurijon @mandre @stephenfin @yatanaka-1007