Skip to content

[release-4.16] OCPBUGS-50547: aws/edge/byovpc: tag edge subnets with shared value #9482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

[release-4.16] OCPBUGS-50547: aws/edge/byovpc: tag edge subnets with shared value #9482

merged 1 commit into from
Mar 28, 2025
+9 −1

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Feb 14, 2025 •
edited
Loading

Previously the subnets created by user (BYO VPC) on edge zones (Local or Wavelength zones) were not tagged with
kubernetes.io/cluster/:shared.

This change ensures installer is also setting the same cluster tag as regular zones.

This PR is a manual backport of #9452, fixing a typo found on #9480

@mtulio
OCPBUGS-48827: aws/edge/byovpc: tag edge subnets with shared value

Verified

This commit was signed with the committer’s verified signature.
mtulio Marco Braga
GPG key ID: F583401A50FF6BD1
Verified
Learn about vigilant mode
Loading
Loading status checks…
eb9c13d 
Previously the subnets created by user (BYO VPC) on edge zones (Local or
Wavelength zones) were not tagged with
kubernetes.io/cluster/<InfraID>:shared.

This change ensures installer is also setting the same cluster tag as
regular zones.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 14, 2025
@openshift-ci-robot
Copy link
Contributor

@mtulio: This pull request references Jira Issue OCPBUGS-48827, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.19.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected dependent Jira Issue OCPBUGS-49594 to target a version in 4.17.0, 4.17.z, but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Previously the subnets created by user (BYO VPC) on edge zones (Local or Wavelength zones) were not tagged with
kubernetes.io/cluster/:shared.

This change ensures installer is also setting the same cluster tag as regular zones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 14, 2025
@mtulio mtulio changed the title OCPBUGS-48827: aws/edge/byovpc: tag edge subnets with shared value [release-4.16] OCPBUGS-50547: aws/edge/byovpc: tag edge subnets with shared value Feb 14, 2025
@openshift-ci-robot
Copy link
Contributor

@mtulio: This pull request references Jira Issue OCPBUGS-50547, which is invalid:

  • expected dependent Jira Issue OCPBUGS-49975 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Previously the subnets created by user (BYO VPC) on edge zones (Local or Wavelength zones) were not tagged with
kubernetes.io/cluster/:shared.

This change ensures installer is also setting the same cluster tag as regular zones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio mtulio mentioned this pull request Feb 14, 2025
Closed
@mtulio
Copy link
Contributor Author

mtulio commented Feb 14, 2025

Wait for e2e.
/hold
/jira refresh
/assign @yunjiang29 @patrickdillon
/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link

@mtulio: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

Wait for e2e.
/hold
/jira refresh
/assign @yunjiang29 @patrickdillon
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

@mtulio: This pull request references Jira Issue OCPBUGS-50547, which is invalid:

  • expected dependent Jira Issue OCPBUGS-49975 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Wait for e2e.
/hold
/jira refresh
/assign @yunjiang29 @patrickdillon
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 14, 2025

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-vsphere-ovn eb9c13d link false /test okd-scos-e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-imdsv2 eb9c13d link false /test e2e-aws-ovn-imdsv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio
Copy link
Contributor Author

mtulio commented Feb 18, 2025

/jira-refresh

@mtulio
Copy link
Contributor Author

mtulio commented Feb 18, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 18, 2025
@openshift-ci-robot
Copy link
Contributor

@mtulio: This pull request references Jira Issue OCPBUGS-50547, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-49975 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-49975 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (yunjiang@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Contributor Author

mtulio commented Feb 18, 2025

Hi @yunjiang29 @patrickdillon , dependent Jira updated. PTAL?
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2025
@yunjiang29
Copy link
Contributor

LGTM

@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2025
@patrickdillon
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 15, 2025
@gpei
Copy link
Contributor

gpei commented Mar 15, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 15, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Mar 17, 2025

/retest-required

1 similar comment
@mtulio
Copy link
Contributor Author

mtulio commented Mar 18, 2025

/retest-required

@mtulio
Copy link
Contributor Author

mtulio commented Mar 19, 2025

Tide is getting stuck frequently :(

@mtulio
Copy link
Contributor Author

mtulio commented Mar 20, 2025

/retest-required

@mtulio
Copy link
Contributor Author

mtulio commented Mar 24, 2025

/test shellcheck
/test tf-lint

@mtulio
Copy link
Contributor Author

mtulio commented Mar 24, 2025

Job timeout

/test shellcheck
/test tf-lint

@mtulio
Copy link
Contributor Author

mtulio commented Mar 25, 2025

Job timeout

/test shellcheck /test tf-lint

@patrickdillon can we skip/override those blockers as the change is unrelated and those are perm failing?

@patrickdillon patrickdillon merged commit bc7dda2 into openshift:release-4.16 Mar 28, 2025
24 of 30 checks passed
@openshift-ci-robot
Copy link
Contributor

@mtulio: Jira Issue OCPBUGS-50547: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-50547 has been moved to the MODIFIED state.

In response to this:

Previously the subnets created by user (BYO VPC) on edge zones (Local or Wavelength zones) were not tagged with
kubernetes.io/cluster/:shared.

This change ensures installer is also setting the same cluster tag as regular zones.

This PR is a manual backport of #9452, fixing a typo found on #9480

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio mtulio deleted the OCPBUGS-50547 branch March 28, 2025 14:54
@openshift-cherrypick-robot
Copy link

@mtulio: new pull request created: #9612

In response to this:

Wait for e2e.
/hold
/jira refresh
/assign @yunjiang29 @patrickdillon
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 28, 2025
Merged
@mtulio
Copy link
Contributor Author

mtulio commented Mar 28, 2025

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link

@mtulio: new pull request could not be created: failed to create pull request against openshift/installer#release-4.15 from head openshift-cherrypick-robot:cherry-pick-9482-to-release-4.15: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-9482-to-release-4.15."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.16.0-202503281507.p0.gbc7dda2.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.16.0-202503281507.p0.gbc7dda2.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.16.0-202503281507.p0.gbc7dda2.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.16.0-202503282104.p0.gbc7dda2.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2025-03-28-235005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon

@pawanpinjarkar pawanpinjarkar

Assignees

@patrickdillon patrickdillon

@yunjiang29 yunjiang29

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mtulio @openshift-ci-robot @openshift-cherrypick-robot @yunjiang29 @patrickdillon @gpei @openshift-bot @openshift-merge-robot