Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.18] OCPBUGS-50690: vsphere - check if host is powered down or on standby before uploading template #9468

Open
wants to merge 2 commits into
base: release-4.18
Choose a base branch
from
Open

[release-4.18] OCPBUGS-50690: vsphere - check if host is powered down or on standby before uploading template #9468

wants to merge 2 commits into from
+3 −4

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9456

/assign jcpowermac

/cherrypick release-4.17 release-4.16

@Nabsku
vsphere: check if host is powered down or on standby before uploading…
Loading
Loading status checks…
e0723a9 
… template

this change was made because the OpenShift IPI workflow sometimes
chooses hosts that aren't available right now, due to being powered down
or being on StandBy (DPM measures)

Signed-off-by: Yannick Wahner <12911176+Nabsku@users.noreply.github.com>
@Nabsku
Rename variable, pull all powerstate checks onto one line and use tha…
7f4999b 
…t variable to check eligibility of host
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 13, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-50649 has been cloned as Jira Issue OCPBUGS-50690. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-50690: vsphere - check if host is powered down or on standby before uploading template

In response to this:

This is an automated cherry-pick of #9456

/assign jcpowermac

/cherrypick release-4.17 release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-50649: vsphere - check if host is powered down or on standby before uploading template [release-4.18] OCPBUGS-50690: vsphere - check if host is powered down or on standby before uploading template Feb 13, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 13, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-50690, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #9456

/assign jcpowermac

/cherrypick release-4.17 release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from rvanderp3 and vr4manta February 13, 2025 14:11
@Nabsku
Copy link
Contributor

Nabsku commented Feb 18, 2025

Hi @jcpowermac, just wondering what the next course of action is with this :) do you need anything from me to proceed with this PR?

@jcpowermac
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: This pull request references Jira Issue OCPBUGS-50690, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 5, 2025
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: This pull request references Jira Issue OCPBUGS-50690, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-50649 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-50649 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @sgaoshang

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sgaoshang March 5, 2025 12:54
@jcpowermac
Copy link
Contributor

Hi @jcpowermac, just wondering what the next course of action is with this :) do you need anything from me to proceed with this PR?

@Nabsku there is nothing left for you to do. The backport PR(s) just need to work through the process.

@vr4manta
Copy link
Contributor

vr4manta commented Mar 5, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@sadasu
Copy link
Contributor

sadasu commented Mar 6, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 6, 2025
@gpei
Copy link
Contributor

gpei commented Mar 7, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 7, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 409dcb7 and 2 for PR HEAD 7f4999b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 409dcb7 and 2 for PR HEAD 7f4999b in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 409dcb7 and 2 for PR HEAD 7f4999b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dac9774 and 2 for PR HEAD 7f4999b in total

10 similar comments
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dac9774 and 2 for PR HEAD 7f4999b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dac9774 and 2 for PR HEAD 7f4999b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dac9774 and 2 for PR HEAD 7f4999b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dac9774 and 2 for PR HEAD 7f4999b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dac9774 and 2 for PR HEAD 7f4999b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dac9774 and 2 for PR HEAD 7f4999b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dac9774 and 2 for PR HEAD 7f4999b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dac9774 and 2 for PR HEAD 7f4999b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dac9774 and 2 for PR HEAD 7f4999b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dac9774 and 2 for PR HEAD 7f4999b in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 19, 2025 •
edited
Loading

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 7f4999b link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dac9774 and 2 for PR HEAD 7f4999b in total

@jcpowermac
Copy link
Contributor

/retest-required

1 similar comment
@jcpowermac
Copy link
Contributor

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvanderp3 rvanderp3

@vr4manta vr4manta

@sgaoshang sgaoshang

Assignees

@jcpowermac jcpowermac

@vr4manta vr4manta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @Nabsku @jcpowermac @vr4manta @sadasu @gpei