Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-2000: Added vSphere provisioning mode support for data disks #9439

Merged
merged 2 commits into from
Apr 1, 2025
Merged

SPLAT-2000: Added vSphere provisioning mode support for data disks #9439

merged 2 commits into from
Apr 1, 2025
+79,506 −45,454

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Feb 5, 2025 •
edited by openshift-ci bot
Loading

SPLAT-2000

Changes

  • Updated installer to contain new provisioning mode field in install-config for vSphere data disks
  • Updated installer to use new CAPV and openshift/API for data disk provisioning mode
  • Updated installer to generate CAPV and MAPI machines with provisioning fields populated

Dependencies

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 5, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2000 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

SPLAT-2000

Changes

  • Updated installer to contain new provisioning mode field in install-config for vSphere data disks
  • Updated installer to use new CAPV and openshift/API for data disk provisioning mode
  • Updated installer to generate CAPV and MAPI machines with provisioning fields populated

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 5, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 5, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2000 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

SPLAT-2000

Changes

  • Updated installer to contain new provisioning mode field in install-config for vSphere data disks
  • Updated installer to use new CAPV and openshift/API for data disk provisioning mode
  • Updated installer to generate CAPV and MAPI machines with provisioning fields populated

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta vr4manta mentioned this pull request Feb 5, 2025
Merged
@vr4manta vr4manta force-pushed the SPLAT-2000 branch 2 times, most recently from f6a91ce to e262609 Compare February 18, 2025 14:02
@vr4manta vr4manta marked this pull request as ready for review February 18, 2025 14:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2025
@vr4manta vr4manta force-pushed the SPLAT-2000 branch 4 times, most recently from b309af6 to ba25076 Compare February 18, 2025 18:09
@rvanderp3
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
@vr4manta
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2025
@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2025
@vr4manta
Copy link
Contributor Author

/retest

@vr4manta
Copy link
Contributor Author

/retest-required

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2025
@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 74c0c30 and 2 for PR HEAD 6875fea in total

@vr4manta
Copy link
Contributor Author

/retest-required

@vr4manta
Copy link
Contributor Author

/retest

@sadasu
Copy link
Contributor

sadasu commented Mar 18, 2025

/test artifacts-images

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 74c0c30 and 2 for PR HEAD 6875fea in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c74674d and 1 for PR HEAD 6875fea in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c74674d and 2 for PR HEAD 6875fea in total

@vr4manta
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c74674d and 2 for PR HEAD 6875fea in total

@vr4manta
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 513176f and 2 for PR HEAD 6875fea in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 99b9ef1 and 1 for PR HEAD 6875fea in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 99b9ef1 and 2 for PR HEAD 6875fea in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8b0c929 and 2 for PR HEAD 6875fea in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c0c6232 and 2 for PR HEAD 6875fea in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6e98328 and 1 for PR HEAD 6875fea in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2025
@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 16eedbc into openshift:main Apr 1, 2025
31 of 37 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack bfd1200 link false /test e2e-azurestack
ci/prow/e2e-azure-ovn-shared-vpc bfd1200 link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-vsphere-ovn-multi-disk bfd1200 link false /test e2e-vsphere-ovn-multi-disk

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon

@rvanderp3 rvanderp3

@jcpowermac jcpowermac

Assignees

@jcpowermac jcpowermac

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vr4manta @openshift-ci-robot @rvanderp3 @jcpowermac @patrickdillon @sadasu @openshift-merge-robot