-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS-3923, CORS-3927: Support confidential cluster installation on SEV-SNP and TDX nodes on GCP #9395
Conversation
Hi @bgartzi. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
abf4942
to
ca991db
Compare
82ded89
to
a143152
Compare
/uncc |
@bgartzi: This pull request references CORS-3923 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set. This pull request references CORS-3927 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@bgartzi: This pull request references CORS-3923 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set. This pull request references CORS-3927 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
a8c7227
to
87b325e
Compare
@bgartzi Suggestions on the explain command outputs. (1) the current outputs:
(2) one sample outputs:
(3) The suggestions:
|
I just addressed your concerns in the last force-pushed version. Could you confir @jianli-wei? I also fixed the validation issue you found when Thanks a lot! |
/retest-required |
@bgartzi Thanks for the quick action! The updates looks good to me, just 2 minor suggestions. (1) The current outputs:
(2) Minor suggestions:
FYI with the above suggestions, the outputs should look like,
|
/approve |
/ok-to-test |
Hey @jianli-wei, @patrickdillon, thanks for the review and testing. I just pushed a new version. Comparing to the previous one:
|
Fixing some linter an gofmt issues that the ci found... I'm not sure about why |
In the latest openshift/api bump confidentialCompute was extended from the previous Enabled/Disabled enum to also consider: - AMDEncryptedVirtualization - AMDEncryptedVirtualizationNestedPaging - IntelTrustedDomainExtensions Update godocs in gcp machinepools to consider those values that will let the user choose from different confidential instance types.
Re-generate data/data/install.openshift.io_installconfigs.yaml based on latest openshift/api bump.
OnHostMaintenance has to be set to Terminate when a ConfidentialCompute value that is not Disabled is configured. Extend the validation so the new values added to ConfidentialCompute are also considered.
Confidential computing in GCP is supported in a limited set of instance types only (see [0]). Other openshift components such as cluster-api already cover this validation. However, running this validation previous to manifest generation can be beneficial for the user. This commit adds validation to GCP instances that have been configured a confidentialCompute value other than Disabled. It checks that the instance type supports the configured confidential computing technology. [0] https://cloud.google.com/confidential-computing/confidential-vm/docs/supported-configurations#machine-type-cpu-zone
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I just dropped the commit bumping the cluster-api-provider-gcp version. The changes I needed were already included by #9528. |
/lgtm |
/label qe-approved |
@bgartzi: This pull request references CORS-3923 which is a valid jira issue. This pull request references CORS-3927 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@bgartzi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
97875b2
into
openshift:main
This patch series aims to support installing a cluster on AMD SEV SNP or TDX confidential nodes on GCP.
Previously, only AMD SEV nodes were supported, which were configured through the
confidentialCompute: Enabled
configuration flag.Now that GCP supports specifying the confidential instance type, we are letting users specify which node type (SEV/SEV-SNP/TDX) they would like to deploy the cluster on.
This can be done by using any of the new available values in
condidentialCompute
such asAMDEncryptedVirtualization
(similar toEnabled
),AMDEncryptedVirtualizationNestedPaging
(AMD SEV-SNP) orIntelTrustedDomainExtensions
(Intel TDX).This series depend on the following patches:
Which have been merged now and and vendored in this patch.
A new cluster-api-provider-gcp release containing the changes I submitted isn't available yet. I created the
data/data/cluster-api/gcp-infrastructure-components.yaml
myself. I'm not sure if that's a valid approach, or if we should rather wait until a new version is out.