Skip to content

OCPBUGS-45726: IBMCloud: Add service overrides #9267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2024
Merged

OCPBUGS-45726: IBMCloud: Add service overrides #9267

merged 2 commits into from
Dec 7, 2024

Conversation

cjschaef
Copy link
Member

@cjschaef cjschaef commented Dec 3, 2024

Add additional IBM Cloud service override support for COS Config
and Global Catalog, for IBM Cloud Terraform plugin and any
Cluster Operators.

Related: https://issues.redhat.com/browse/OCPBUGS-34974

@cjschaef
OCPBUGS-34974: IBMCloud: Add service overrides
Loading
Loading status checks…
ba583a2 
Add additional IBM Cloud service override support for COS Config
and Global Catalog, for IBM Cloud Terraform plugin and any
Cluster Operators.

Related: https://issues.redhat.com/browse/OCPBUGS-34974
@cjschaef
IBMCloud: Bump IBM Cloud TF plugin
820b2de 
Bump the IBM Cloud TF plugin commit to pull in required
changes for COS endpoint configuration.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 3, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 3, 2024
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-34974, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.18.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-34974 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add additional IBM Cloud service override support for COS Config
and Global Catalog, for IBM Cloud Terraform plugin and any
Cluster Operators.

Related: https://issues.redhat.com/browse/OCPBUGS-34974

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cjschaef
Copy link
Member Author

cjschaef commented Dec 3, 2024

I think I need a new Jira opened manually as well, since automated cherry-pick didn't work.

@cjschaef
Copy link
Member Author

cjschaef commented Dec 5, 2024

/retitle OCPBUGS-45726: IBMCloud: Add service overrides

@openshift-ci openshift-ci bot changed the title OCPBUGS-34974: IBMCloud: Add service overrides OCPBUGS-45726: IBMCloud: Add service overrides Dec 5, 2024
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-45726, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-45726 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add additional IBM Cloud service override support for COS Config
and Global Catalog, for IBM Cloud Terraform plugin and any
Cluster Operators.

Related: https://issues.redhat.com/browse/OCPBUGS-34974

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cjschaef
Copy link
Member Author

cjschaef commented Dec 5, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 5, 2024
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-45726, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-34974 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-34974 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gpei December 5, 2024 22:45
@cjschaef cjschaef marked this pull request as ready for review December 5, 2024 22:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2024
@openshift-ci openshift-ci bot requested review from rvanderp3 and sadasu December 5, 2024 22:46
@jeffnowicki
Copy link
Contributor

/retest

@jeffnowicki
Copy link
Contributor

/test e2e-openstack-proxy

@sadasu
Copy link
Contributor

sadasu commented Dec 6, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 6, 2024
@sadasu
Copy link
Contributor

sadasu commented Dec 6, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@rvanderp3
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
@cjschaef
Copy link
Member Author

cjschaef commented Dec 6, 2024

Looking at e2e-ibmcloud-ovn failures:

  • [Jira:"Networking / router"] monitor test service-type-load-balancer-availability setup - I've seen this fail frequently, and it appears it too may be related to etcd performance as well: OCPBUGS-42869
  • [bz-Etcd] clusteroperator/etcd should not change condition/Available - I think this tracks back to the known etcd performance limitation for IBM Cloud

So, from what I see, the failures are due to the known etcd limitations we have and not in regard to the changes in this PR.

@gpei
Copy link
Contributor

gpei commented Dec 7, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 7, 2024

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-ovn 820b2de link false /test e2e-ibmcloud-ovn
ci/prow/e2e-openstack-proxy 820b2de link false /test e2e-openstack-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 15a9f9e into openshift:release-4.17 Dec 7, 2024
39 of 41 checks passed
@openshift-ci-robot
Copy link
Contributor

@cjschaef: Jira Issue OCPBUGS-45726: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-45726 has been moved to the MODIFIED state.

In response to this:

Add additional IBM Cloud service override support for COS Config
and Global Catalog, for IBM Cloud Terraform plugin and any
Cluster Operators.

Related: https://issues.redhat.com/browse/OCPBUGS-34974

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.17.0-202412090803.p0.g15a9f9e.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.17.0-202412090803.p0.g15a9f9e.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.17.0-202412090803.p0.g15a9f9e.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.17.0-202412090803.p0.g15a9f9e.assembly.stream.el9.
All builds following this will include this PR.

@cjschaef
Copy link
Member Author

cjschaef commented Dec 9, 2024

/cherrypick release-4.16

@openshift-cherrypick-robot
Copy link

@cjschaef: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.

Error messagestatus code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#list-pull-requests-files","status":"406"}

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cjschaef cjschaef deleted the ocpbugs-34974-4.17 branch December 9, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpei gpei

@rvanderp3 rvanderp3

@sadasu sadasu

Assignees

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cjschaef @openshift-ci-robot @jeffnowicki @sadasu @rvanderp3 @gpei @openshift-bot @openshift-cherrypick-robot