Skip to content

[release-4.17] OCPBUGS-45340: move GCP zone filtering client-side #9264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

[release-4.17] OCPBUGS-45340: move GCP zone filtering client-side #9264

merged 1 commit into from
Jan 17, 2025
+13 −17

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9240

/assign jupierce

@patrickdillon
OCPBUGS-44193: move GCP zone filtering client-side
Loading
Loading status checks…
bfabf1a 
This commit removes GCP server-side filtering when listing
zones. GCP imposes a "filtered list cost overhead quota" which
limits the amount of server-side filtering we can utilize. More
information can be found here:

https://cloud.google.com/compute/api-quota

We have seen CI jobs failing due to:

level=fatal msg=failed to fetch Cluster API Machine Manifests:
failed to generate asset "Cluster API Machine Manifests": failed
to fetch availability zones: failed to get zones for project:
failed to get zones from project XXXXXXXXXXXXXXXXXXXXXXXX: googleapi:
Error 403: Quota exceeded for quota metric 'Filtered list cost overhead'
and limit 'Filtered list cost overhead per minute' of service
'compute.googleapis.com' for consumer 'project_number:711936183532'.

GCP recommends utilizing client-side filters to resolve this:
https://cloud.google.com/compute/docs/api/best-practices#client-side-filter
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 3, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-45081 has been cloned as Jira Issue OCPBUGS-45340. Will retitle bug to link to clone.
/retitle [release-4.17] OCPBUGS-45340: move GCP zone filtering client-side

In response to this:

This is an automated cherry-pick of #9240

/assign jupierce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jupierce
Copy link
Contributor

jupierce commented Dec 3, 2024

While frequency of failures is decreasing, it can happen with 4.17 builds: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/59433/rehearse-59433-pull-ci-openshift-kubernetes-release-4.17-k8s-e2e-gcp-ovn/1863798526614441984 .

@openshift-ci openshift-ci bot changed the title [release-4.17] OCPBUGS-45081: move GCP zone filtering client-side [release-4.17] OCPBUGS-45340: move GCP zone filtering client-side Dec 3, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 3, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-45340, which is invalid:

  • expected dependent Jira Issue OCPBUGS-45081 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #9240

/assign jupierce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jupierce
Copy link
Contributor

jupierce commented Dec 4, 2024

/retest

@sadasu
Copy link
Contributor

sadasu commented Jan 8, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 8, 2025
@sadasu
Copy link
Contributor

sadasu commented Jan 8, 2025

@jupierce , @patrickdillon do we want ti merge this in 4.17?

@gpei
Copy link
Contributor

gpei commented Jan 11, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 11, 2025
@openshift-ci-robot
Copy link
Contributor

@gpei: This pull request references Jira Issue OCPBUGS-45340, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-45081 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-45081 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gpei January 11, 2025 08:19
@gpei
Copy link
Contributor

gpei commented Jan 11, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 11, 2025
@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 25875b2 and 2 for PR HEAD bfabf1a in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cc9298d into openshift:release-4.17 Jan 17, 2025
21 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-45340: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-45340 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #9240

/assign jupierce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.17.0-202501172335.p0.gcc9298d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.17.0-202501172335.p0.gcc9298d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.17.0-202501172335.p0.gcc9298d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.17.0-202501180234.p0.gcc9298d.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon

@sadasu sadasu

@gpei gpei

Assignees

@patrickdillon patrickdillon

@jupierce jupierce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @jupierce @sadasu @gpei @patrickdillon @openshift-bot