Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] OCPBUGS-43528: Prevent race with provisioning-interface service #9110

Merged
merged 3 commits into from
Mar 5, 2025
Merged

[release-4.17] OCPBUGS-43528: Prevent race with provisioning-interface service #9110

merged 3 commits into from
Mar 5, 2025
+14 −1

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #8985

/assign zaneb

zaneb added 3 commits October 18, 2024 00:08
@zaneb
OCPBUGS-36869: Avoid races with provisioning-interface service
6e13eba 
When the provisioning network is disabled in Metal IPI, the
provisioning-interface service on the bootstrap can still run to set the
BootstrapProvisioningIP address - however, it does so on the main
(external) network interface. Since this service restarts the interface,
it must not run at the same time as anything that is accessing the
network (e.g. to pull container images) lest those other services be
interrupted. In particular, oneshot services with dependencies must not
fail.

To prevent the network interface being restarted at an inopportune time,
ensure all units have ordering dependencies with
provisioning-interface.service.
@zaneb
Move extract-machine-os command to a script
39d9c47
@zaneb
Retry extracting Machine OS on failure
8ccea8a 
If e.g. a network interruption causes a failure to extract the machine
OS, try again. (Retries at the systemd level do not help, because
dependent services will not start, so it must be retried within the
script.)
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 18, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36869 has been cloned as Jira Issue OCPBUGS-43528. Will retitle bug to link to clone.
/retitle [release-4.17] OCPBUGS-43528: Prevent race with provisioning-interface service

In response to this:

This is an automated cherry-pick of #8985

/assign zaneb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.17] OCPBUGS-36869: Prevent race with provisioning-interface service [release-4.17] OCPBUGS-43528: Prevent race with provisioning-interface service Oct 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 18, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-43528, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #8985

/assign zaneb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 18, 2024
@openshift-ci openshift-ci bot requested review from honza and iurygregory October 18, 2024 00:09
@zaneb
Copy link
Member

zaneb commented Oct 18, 2024

/lgtm
/label backport-risk-assessed
/jira refresh

@openshift-ci-robot
Copy link
Contributor

@zaneb: This pull request references Jira Issue OCPBUGS-43528, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/lgtm
/label backport-risk-assessed
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Oct 18, 2024
@zaneb
Copy link
Member

zaneb commented Oct 18, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 18, 2024
@openshift-ci-robot
Copy link
Contributor

@zaneb: This pull request references Jira Issue OCPBUGS-43528, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-36869 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-36869 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact:
/cc @jadhaj

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 18, 2024
@openshift-ci openshift-ci bot requested a review from jadhaj October 18, 2024 02:15
@honza
Copy link
Member

honza commented Oct 18, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@zaneb
Copy link
Member

zaneb commented Dec 23, 2024

/retest

@hroyrh
Copy link

hroyrh commented Feb 12, 2025

/retest-required

@jadhaj
Copy link

jadhaj commented Mar 5, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 5, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 5, 2025 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn 8ccea8a link false /test e2e-metal-ipi-ovn
ci/prow/e2e-metal-ipi-ovn-virtualmedia 8ccea8a link false /test e2e-metal-ipi-ovn-virtualmedia
ci/prow/e2e-metal-ipi-ovn-dualstack 8ccea8a link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-ovn-swapped-hosts 8ccea8a link false /test e2e-metal-ipi-ovn-swapped-hosts

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ea5bb11 and 2 for PR HEAD 8ccea8a in total

@openshift-merge-bot openshift-merge-bot bot merged commit b4349fd into openshift:release-4.17 Mar 5, 2025
20 of 24 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-43528: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43528 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #8985

/assign zaneb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.17.0-202503052141.p0.gb4349fd.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.17.0-202503052141.p0.gb4349fd.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.17.0-202503052141.p0.gb4349fd.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.17.0-202503052141.p0.gb4349fd.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honza honza

@iurygregory iurygregory

@jadhaj jadhaj

Assignees

@zaneb zaneb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @zaneb @honza @hroyrh @jadhaj @openshift-bot