Skip to content

OCPBUGS-36677: Power VS: Enable incoming traffic on port 5000 during installation in a restricted network #8711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.16
Choose a base branch
from
Open

OCPBUGS-36677: Power VS: Enable incoming traffic on port 5000 during installation in a restricted network #8711

wants to merge 1 commit into from
+8 −1

Conversation

AshwinHIBM
Copy link
Contributor

If source network address translation is not allowed, i.e. during an installation in a restricted network, incoming traffic on port 5000 should be allowed as the user created image registry is accessible on this port. Allow it.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 8, 2024
@openshift-ci-robot
Copy link
Contributor

@AshwinHIBM: This pull request references Jira Issue OCPBUGS-36677, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-36677 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If source network address translation is not allowed, i.e. during an installation in a restricted network, incoming traffic on port 5000 should be allowed as the user created image registry is accessible on this port. Allow it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from barbacbd and patrickdillon July 8, 2024 12:44
@AshwinHIBM
Copy link
Contributor Author

/assign @mjturek
How can I create a bug for 4.17 in case we're specifically looking at this issue for 4.16?

@AshwinHIBM AshwinHIBM force-pushed the port5000-tf-disconnected branch 2 times, most recently from a9e8708 to 14105d0 Compare July 10, 2024 08:32
@AshwinHIBM AshwinHIBM force-pushed the port5000-tf-disconnected branch from 14105d0 to ac84d59 Compare July 11, 2024 04:46
@AshwinHIBM AshwinHIBM changed the title OCPBUGS-36677: Power VS: Enable incoming traffic on port 5000 during installation in a restricted network OCPBUGS-36909: Power VS: Enable incoming traffic on port 5000 during installation in a restricted network Jul 12, 2024
@openshift-ci-robot
Copy link
Contributor

@AshwinHIBM: This pull request references Jira Issue OCPBUGS-36909, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.17.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-36909 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If source network address translation is not allowed, i.e. during an installation in a restricted network, incoming traffic on port 5000 should be allowed as the user created image registry is accessible on this port. Allow it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@AshwinHIBM AshwinHIBM changed the title OCPBUGS-36909: Power VS: Enable incoming traffic on port 5000 during installation in a restricted network OCPBUGS-36677: Power VS: Enable incoming traffic on port 5000 during installation in a restricted network Jul 12, 2024
@openshift-ci-robot
Copy link
Contributor

@AshwinHIBM: This pull request references Jira Issue OCPBUGS-36677, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-36677 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

If source network address translation is not allowed, i.e. during an installation in a restricted network, incoming traffic on port 5000 should be allowed as the user created image registry is accessible on this port. Allow it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@AshwinHIBM
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@AshwinHIBM: This pull request references Jira Issue OCPBUGS-36677, which is invalid:

  • expected Jira Issue OCPBUGS-36677 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mjturek
Copy link
Contributor

mjturek commented Jul 16, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@mjturek
Copy link
Contributor

mjturek commented Jul 16, 2024

/assign sadasu

@sadasu
Copy link
Contributor

sadasu commented Jul 23, 2024

/approve

@sadasu
Copy link
Contributor

sadasu commented Jul 23, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 23, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@AshwinHIBM
Copy link
Contributor Author

/test e2e-aws-ovn

@mjturek
Copy link
Contributor

mjturek commented Aug 1, 2024

/jira-refresh

@mjturek
Copy link
Contributor

mjturek commented Aug 1, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@mjturek: This pull request references Jira Issue OCPBUGS-36677, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-36677 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@AshwinHIBM
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@AshwinHIBM: This pull request references Jira Issue OCPBUGS-36677, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-36677 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@AshwinHIBM
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 6, 2024
@openshift-ci-robot
Copy link
Contributor

@AshwinHIBM: This pull request references Jira Issue OCPBUGS-36677, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-36909 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-36909 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @juliemathew

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 6, 2024
@openshift-ci openshift-ci bot requested a review from juliemathew August 6, 2024 10:53
@AshwinHIBM
Copy link
Contributor Author

@sadasu Wondering why this isn't getting merged...

@sadasu
Copy link
Contributor

sadasu commented Nov 5, 2024

@sadasu Wondering why this isn't getting merged...

QE needs to add the cherry-pick-approved label. Can you add them to this review?

@AshwinHIBM
Copy link
Contributor Author

@sadasu Wondering why this isn't getting merged...

QE needs to add the cherry-pick-approved label. Can you add them to this review?

@juliemathew Can you PTAL?

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 5, 2025
@sadasu
Copy link
Contributor

sadasu commented Feb 14, 2025

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2025
@sadasu
Copy link
Contributor

sadasu commented Mar 14, 2025

@AshwinHIBM , could you ping QE one more time? Maybe they are not looking at their github notifications.

@mjturek
Copy link
Contributor

mjturek commented Mar 25, 2025

/assign gpei

@gpei
Copy link
Contributor

gpei commented Mar 26, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 26, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 145d7e7 and 2 for PR HEAD ac84d59 in total

@sadasu
Copy link
Contributor

sadasu commented Apr 10, 2025

/retest-required

@sadasu
Copy link
Contributor

sadasu commented Apr 15, 2025

/override ci/prow/yaml-lint

@sadasu
Copy link
Contributor

sadasu commented Apr 15, 2025

/override ci/prow/tf-lint

@sadasu
Copy link
Contributor

sadasu commented Apr 15, 2025

/override ci/prow/shellcheck

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@sadasu: Overrode contexts on behalf of sadasu: ci/prow/yaml-lint

In response to this:

/override ci/prow/yaml-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@sadasu: Overrode contexts on behalf of sadasu: ci/prow/tf-lint

In response to this:

/override ci/prow/tf-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@sadasu: Overrode contexts on behalf of sadasu: ci/prow/shellcheck

In response to this:

/override ci/prow/shellcheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@AshwinHIBM: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbacbd barbacbd

@patrickdillon patrickdillon

@juliemathew juliemathew

Assignees

@gpei gpei

@sadasu sadasu

@mjturek mjturek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@AshwinHIBM @openshift-ci-robot @mjturek @sadasu @openshift-bot @gpei @barbacbd