Skip to content

Revert "Revert "CNTRLPLANE-112: Enable MIv3 for CNO/CNCC on managed Azure"" #6012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

Revert "Revert "CNTRLPLANE-112: Enable MIv3 for CNO/CNCC on managed Azure"" #6012

merged 1 commit into from
Apr 14, 2025
+8 −37

Conversation

bryan-cox
Copy link
Member

@bryan-cox bryan-cox commented Apr 9, 2025 •
edited
Loading

Reverts #5860

This PR:

Internal Slack Conversation: https://redhat-internal.slack.com/archives/C07RFUYNXDF/p1742312125268599?thread_ts=1741623807.150429&cid=C07RFUYNXDF

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 9, 2025 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references CNTRLPLANE-112 which is a valid jira issue.

In response to this:

Reverts #5860

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from enxebre and sjenning April 9, 2025 14:17
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Apr 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Apr 9, 2025
@cwbotbot
Copy link

cwbotbot commented Apr 9, 2025 •
edited
Loading

Test Results

e2e-aws

e2e-aks

@bryan-cox
Copy link
Member Author

/test e2e-aks

@bryan-cox
Revert "Revert "CNTRLPLANE-112: Enable MIv3 for CNO/CNCC on managed A…

Verified

This commit was signed with the committer’s verified signature.
bryan-cox Bryan Cox
GPG key ID: 117B7793559C9636
Verified
Learn about vigilant mode
Loading
Loading status checks…
f21996b 
…zure""
@bryan-cox bryan-cox force-pushed the revert-5860-revert-5837-CNTRLPLANE-112-cno-cncc branch from 5d6d8aa to f21996b Compare April 9, 2025 19:39
@bryan-cox
Copy link
Member Author

/retest-required

@bryan-cox
Copy link
Member Author

/test e2e-aks

@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Copy link
Member Author

/test e2e-aks

@jparrill
Copy link
Contributor

/lgtm

@jparrill
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references CNTRLPLANE-112 which is a valid jira issue.

In response to this:

Reverts #5860

It was previously reverted by @kyrtapz as the change affected CNCC on azure standalone. Example here.

Internal Slack Conversation: https://redhat-internal.slack.com/archives/C07RFUYNXDF/p1742312125268599?thread_ts=1741623807.150429&cid=C07RFUYNXDF

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references CNTRLPLANE-112 which is a valid jira issue.

In response to this:

Reverts #5860

This PR:

  • was originally introduced in

It was previously reverted by @kyrtapz as the change affected CNCC on azure standalone. Example here.

Internal Slack Conversation: https://redhat-internal.slack.com/archives/C07RFUYNXDF/p1742312125268599?thread_ts=1741623807.150429&cid=C07RFUYNXDF

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references CNTRLPLANE-112 which is a valid jira issue.

In response to this:

Reverts #5860

This PR:

Internal Slack Conversation: https://redhat-internal.slack.com/archives/C07RFUYNXDF/p1742312125268599?thread_ts=1741623807.150429&cid=C07RFUYNXDF

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member Author

/override "Red Hat Konflux / control-plane-operator-enterprise-contract / control-plane-operator-main"

@bryan-cox
Copy link
Member Author

/override "Red Hat Konflux / control-plane-operator-main-on-pull-request"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

@bryan-cox: Overrode contexts on behalf of bryan-cox: Red Hat Konflux / control-plane-operator-enterprise-contract / control-plane-operator-main

In response to this:

/override "Red Hat Konflux / control-plane-operator-enterprise-contract / control-plane-operator-main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bryan-cox
Copy link
Member Author

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

@bryan-cox: Overrode contexts on behalf of bryan-cox: Red Hat Konflux / control-plane-operator-main-on-pull-request

In response to this:

/override "Red Hat Konflux / control-plane-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

@bryan-cox: Overrode contexts on behalf of bryan-cox: Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bryan-cox
Copy link
Member Author

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

@bryan-cox: Overrode contexts on behalf of bryan-cox: Red Hat Konflux / hypershift-operator-main-on-pull-request

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references CNTRLPLANE-112 which is a valid jira issue.

In response to this:

Reverts #5860

This PR:

Internal Slack Conversation: https://redhat-internal.slack.com/archives/C07RFUYNXDF/p1742312125268599?thread_ts=1741623807.150429&cid=C07RFUYNXDF

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6c62eaa and 2 for PR HEAD f21996b in total

@openshift-merge-bot openshift-merge-bot bot merged commit 2096f62 into openshift:main Apr 14, 2025
14 of 18 checks passed
@bryan-cox bryan-cox deleted the revert-5860-revert-5837-CNTRLPLANE-112-cno-cncc branch April 14, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre

@sjenning sjenning

Assignees

@jparrill jparrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bryan-cox @openshift-ci-robot @cwbotbot @jparrill