Skip to content

OCPBUGS-54533: Update DNS names for ovn-kubernetes cp metrics #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

OCPBUGS-54533: Update DNS names for ovn-kubernetes cp metrics #6007

merged 1 commit into from
Apr 14, 2025
+8 −4

Conversation

bryan-cox
Copy link
Member

@bryan-cox bryan-cox commented Apr 8, 2025 •
edited
Loading

What this PR does / why we need it:
This commit updates the DNS names for ovn-kubernetes-control-plane from ovnkube-control-plane to ovn-kubernetes-control-plane. This is what is expected by the cluster network operator.

Which issue(s) this PR fixes:
Fixes OCPBUGS-54533

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Sorry, something went wrong.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 8, 2025
@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-54533, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
This commit renames the ovn-kubernetes-control-plane service to ovn-kube-control-plane. This matches the name of the serving certificate secret.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sorry, something went wrong.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-area labels Apr 8, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Apr 8, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
@enxebre
Copy link
Member

enxebre commented Apr 9, 2025

will this leave any resource behind during an upgrade?

@bryan-cox
Copy link
Member Author

/test all

@cwbotbot
Copy link

cwbotbot commented Apr 9, 2025 •
edited
Loading

Test Results

e2e-aws

e2e-aks

Failed Tests

Total failed tests: 9

  • TestNodePool
  • TestNodePool/HostedCluster0
  • TestNodePool/HostedCluster0/Main
  • TestNodePool/HostedCluster0/Main/TestNTOMachineConfigAppliedInPlace
  • TestNodePool/HostedCluster0/Main/TestNTOMachineConfigAppliedInPlace/EnsureNoCrashingPods

... and 4 more failed tests

@bryan-cox bryan-cox force-pushed the OCPBUGS-54533 branch 4 times, most recently from a7d6766 to 642d8ac Compare April 10, 2025 19:27
@bryan-cox
Update DNS names for ovn-kubernetes cp metrics

Verified

This commit was signed with the committer’s verified signature.
bryan-cox Bryan Cox
GPG key ID: 117B7793559C9636
Verified
Learn about vigilant mode
Loading
Loading status checks…
e4f063d 
This commit updates the DNS names for ovn-kubernetes-control-plane from
ovnkube-control-plane to ovn-kubernetes-control-plane. This is what is
expected by the cluster network operator.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox bryan-cox changed the title OCPBUGS-54533: Rename ovn-kubernetes-control-plane service OCPBUGS-54533: Update DNS names for ovn-kubernetes cp metrics Apr 10, 2025
@bryan-cox
Copy link
Member Author

/test all

@bryan-cox
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 10, 2025
@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-54533, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 10, 2025
@bryan-cox
Copy link
Member Author

/retest

@csrwng
Copy link
Contributor

csrwng commented Apr 11, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2025
@bryan-cox bryan-cox marked this pull request as ready for review April 11, 2025 13:48
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2025
@openshift-ci openshift-ci bot requested review from rtheis and sjenning April 11, 2025 13:50
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6efaf27 and 2 for PR HEAD e4f063d in total

@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Copy link
Member Author

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

@bryan-cox
Copy link
Member Author

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 13, 2025

@bryan-cox: Overrode contexts on behalf of bryan-cox: Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 13, 2025

@bryan-cox: Overrode contexts on behalf of bryan-cox: Red Hat Konflux / hypershift-operator-main-on-pull-request

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bryan-cox
Copy link
Member Author

/test all

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0b26461 and 1 for PR HEAD e4f063d in total

@bryan-cox
Copy link
Member Author

/retest

1 similar comment
@bryan-cox
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6c62eaa and 2 for PR HEAD e4f063d in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c99fd69 and 1 for PR HEAD e4f063d in total

@openshift-merge-bot openshift-merge-bot bot merged commit 63de0d8 into openshift:main Apr 14, 2025
15 of 16 checks passed
@openshift-ci-robot
Copy link

@bryan-cox: Jira Issue OCPBUGS-54533: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-54533 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
This commit updates the DNS names for ovn-kubernetes-control-plane from ovnkube-control-plane to ovn-kubernetes-control-plane. This is what is expected by the cluster network operator.

Which issue(s) this PR fixes:
Fixes OCPBUGS-54533

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sorry, something went wrong.

@bryan-cox bryan-cox deleted the OCPBUGS-54533 branch April 14, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtheis rtheis

@sjenning sjenning

Assignees

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bryan-cox @openshift-ci-robot @enxebre @cwbotbot @csrwng