Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: add steps:count1h recording rule #547

Merged

Conversation

simonpasquier
Copy link
Contributor

Follow-up of the discussion on #544. This PR creates a recorded metric which we can use in the follow-up recording rules instead of hardcoding count_over_time(vector(1)[1h:5m]) everywhere.

Verified

This commit was signed with the committer’s verified signature.
simonpasquier Simon Pasquier
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@simonpasquier: This pull request explicitly references no jira issue.

In response to this:

Follow-up of the discussion on #544. This PR creates a recorded metric which we can use in the follow-up recording rules instead of hardcoding count_over_time(vector(1)[1h:5m]) everywhere.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 1, 2024
@simonpasquier
Copy link
Contributor Author

/cc @saswatamcode

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2024
@saswatamcode
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saswatamcode, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [saswatamcode,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0453f45 into openshift:master Oct 1, 2024
9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: telemeter
This PR has been included in build telemeter-container-v4.18.0-202410011141.p0.g0453f45.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants