Skip to content

NO-ISSUE: Fix shellcheck complaints #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

zaneb
Copy link
Member

@zaneb zaneb commented Nov 4, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from dtantsur and jlebon November 4, 2024 03:03
Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@zaneb
Copy link
Member Author

zaneb commented Nov 4, 2024

/cc @derekhiggins

@openshift-ci openshift-ci bot requested a review from derekhiggins November 4, 2024 03:17
@zaneb
Copy link
Member Author

zaneb commented Nov 4, 2024

This code doesn't actually cause any problems, but must be changed to allow shellcheck to run on these files (in openshift/release#58429). Therefore, skipping Jira ticket check.
/retitle: NOISSUE: Fix shellcheck complaints

@openshift-ci openshift-ci bot changed the title Fix shellcheck complaints : NOISSUE: Fix shellcheck complaints Nov 4, 2024
@zaneb zaneb changed the title : NOISSUE: Fix shellcheck complaints NO-ISSUE: Fix shellcheck complaints Nov 4, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2024
@openshift-ci-robot
Copy link

@zaneb: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elfosardo
Copy link
Contributor

/override ci/prow/okd-images

@elfosardo
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Nov 4, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/okd-images

In response to this:

/override ci/prow/okd-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 62fbf3f and 2 for PR HEAD 1455076 in total

3 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 62fbf3f and 2 for PR HEAD 1455076 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 62fbf3f and 2 for PR HEAD 1455076 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 62fbf3f and 2 for PR HEAD 1455076 in total

@dtantsur
Copy link
Member

dtantsur commented Nov 5, 2024

/override ci/prow/okd-images

This change has nothing to do with image building.

Copy link

openshift-ci bot commented Nov 5, 2024

@dtantsur: Overrode contexts on behalf of dtantsur: ci/prow/okd-images

In response to this:

/override ci/prow/okd-images

This change has nothing to do with image building.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Nov 5, 2024

@zaneb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fd32b76 into openshift:main Nov 5, 2024
6 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-os-images
This PR has been included in build ose-machine-os-images-container-v4.18.0-202411051638.p0.gfd32b76.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants