STOR-2263: Enable csi resize and inline volume support for smb csi driver #358
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@Phaow: This pull request references STOR-2263 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
Hi @mpatlasov @rhrmo , could you please help take a look when you get a chance? Thank you! |
|
/assign @mpatlasov @rhrmo |
|
Thank you for this PR, @Phaow , it's neat! See one inline comment about smb-csi-driver-role. Before merging, please make sure that openshift/csi-driver-smb#21 merged first, and e2e tests pass here. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpatlasov, Phaow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label tide/merge-method-squash |
openshift-ci
bot
added
the
tide/merge-method-squash
|
/retest |
|
@Phaow: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The smb windows jobs failed are caused by https://issues.redhat.com/browse/OCPQE-28374 ( |
| controllerExpansion: false | ||
| nodeExpansion: false | ||
| controllerExpansion: true | ||
| nodeExpansion: true | ||
| snapshotDataSource: false |
There was a problem hiding this comment.
nit: this CSI driver doesn't support nodeExpansion...
There was a problem hiding this comment.
Hm... We follow upstream commit here.
There was a problem hiding this comment.
upstream did wrong copy/paste. :-)
There was a problem hiding this comment.
This is not show-stopper for this PR, right? (we'll try to fix it upstream first, and then bring this one-line change to our downstream)
There was a problem hiding this comment.
@gnufied @mpatlasov Good catch, thank you! I'll try to fix it upstream firstly and cherry-pick it back to make it correct. Out of curious the e2e passed so does it mean the nodeExpansion tests seems could not catch the incorrect config? Will do some research on the resize e2e tests later.
|
/lgtm |
|
/label qe-approved Pre merge e2e tests looks good. $ ginkgo run -v test/e2e --timeout=30min
------------------------------
Ran 15 of 16 Specs in 614.804 seconds
SUCCESS! -- 15 Passed | 0 Failed | 0 Pending | 1 Skipped
You're using deprecated Ginkgo functionality:
============================================= |
openshift-ci
bot
added
the
qe-approved
|
@Phaow: This pull request references STOR-2263 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit 50baad1
into
openshift:main
|
[ART PR BUILD NOTIFIER] Distgit: ose-aws-efs-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-aws-ebs-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: csi-driver-manila-operator |
|
[ART PR BUILD NOTIFIER] Distgit: azure-file-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-azure-disk-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-smb-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-openstack-cinder-csi-driver-operator |
STOR-2263: Enable csi resize and inline volume support for smb csi driver