add support for distributing day2 volume[group]snapshotclasses #3153
Conversation
|
I think you are missing RBACs for ocs-provider-server to get V[G]SC |
when the volume[group]storageclass mentioned in storageconsumer doesn't match one of the known names we consider that being unmanaged day2 created v[g]sc and we update the dynamic params corresponding to the driver and then send as a resource to be created & owned by storageclient in client-op. Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
|
rebased on main. |
| case RbdDriverName: | ||
| clientProfileName = consumerConfig.GetRbdClientProfileName() | ||
| provisionerSecretName = consumerConfig.GetCsiRbdProvisionerSecretName() | ||
| storageId = rbdStorageId | ||
| case CephFSDriverName: | ||
| clientProfileName = consumerConfig.GetCephFsClientProfileName() | ||
| provisionerSecretName = consumerConfig.GetCsiCephFsProvisionerSecretName() | ||
| storageId = cephFsStorageId |
There was a problem hiding this comment.
Is the expectation that when the user creates this groupsnapshot class, they will provide it with "pool"/"fsName" parameters? Or do we want to fill in some default values?
There was a problem hiding this comment.
they will provide it with "pool"/"fsName" parameters
- yes, that's the expectation which is inline w/ current documented procedures
| case NfsDriverName: | ||
| clientProfileName = consumerConfig.GetNfsClientProfileName() | ||
| provisionerSecretName = consumerConfig.GetCsiNfsProvisionerSecretName() | ||
| storageId = nfsStorageId |
There was a problem hiding this comment.
NFS groupsnapshot is not supported right?
There was a problem hiding this comment.
then this case will never be hit, I don't think that'll be an issue until we support that and these params will differ.
There was a problem hiding this comment.
When we do declare support for this the params will NOT differ as out NFS implementatin is just a protocol layer on top of CephFS. Which means, to the best of my understanding, that storageId should and can be the same
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, nb-ohad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 3f085cd
into
red-hat-storage:main
|
/cherrypick release-4.19 |
|
@leelavg: new pull request created: #3161 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
when the volume[group]storageclass mentioned in storageconsumer doesn't match one of the known names we consider that being unmanaged day2 created v[g]sc and we update the dynamic params corresponding to the driver and then send as a resource to be created & owned by storageclient in client-op.