Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-2245: add manifest-topology.yaml for topology related feature and test #302

Merged
merged 1 commit into from
Mar 30, 2025
Merged

STOR-2245: add manifest-topology.yaml for topology related feature and test #302

merged 1 commit into from
Mar 30, 2025
+30 −0

Conversation

duanwei33
Copy link
Contributor

When adding the multi-zone/multi-vcenter CI, some cases will check if there are at least 2 nodes in the same zone and need the topology Capability.
The other profile that doesn't have the zonal configuration will still need the previous manifest. (The topology key is null)

@duanwei33
add manifest-topology.yaml for topology related feature and test
Loading
Loading status checks…
50546df 
Adding back the commented line
@openshift-ci openshift-ci bot requested review from jsafrane and mpatlasov March 27, 2025 06:57
@duanwei33
Copy link
Contributor Author

/retest-required

@duanwei33 duanwei33 mentioned this pull request Mar 28, 2025
Open
@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duanwei33, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025
@jsafrane
Copy link
Contributor

/label acknowledge-critical-fixes-only
this only adds a manifest, it's not used yet.

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 28, 2025
@duanwei33 duanwei33 changed the title add manifest-topology.yaml for topology related feature and test STOR-2245: add manifest-topology.yaml for topology related feature and test Mar 29, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 29, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 29, 2025 •
edited by openshift-ci bot
Loading

@duanwei33: This pull request references STOR-2245 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

When adding the multi-zone/multi-vcenter CI, some cases will check if there are at least 2 nodes in the same zone and need the topology Capability.
The other profile that doesn't have the zonal configuration will still need the previous manifest. (The topology key is null)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@duanwei33
Copy link
Contributor Author

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 29, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 29, 2025 •
edited by openshift-ci bot
Loading

@duanwei33: This pull request references STOR-2245 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

When adding the multi-zone/multi-vcenter CI, some cases will check if there are at least 2 nodes in the same zone and need the topology Capability.
The other profile that doesn't have the zonal configuration will still need the previous manifest. (The topology key is null)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a1e64d7 and 2 for PR HEAD 50546df in total

@duanwei33
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 30, 2025 •
edited
Loading

@duanwei33: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-zones 50546df link false /test e2e-vsphere-zones
ci/prow/okd-scos-e2e-aws-ovn 50546df link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@duanwei33
Copy link
Contributor Author

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 8a4da29 into openshift:main Mar 30, 2025
12 of 14 checks passed
@duanwei33
Copy link
Contributor Author

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link

@duanwei33: new pull request created: #303

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 31, 2025
Open
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-vmware-vsphere-csi-driver-operator
This PR has been included in build ose-vmware-vsphere-csi-driver-operator-container-v4.19.0-202503311540.p0.g8a4da29.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane

@mpatlasov mpatlasov

Assignees

@jsafrane jsafrane

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@duanwei33 @jsafrane @openshift-ci-robot @openshift-cherrypick-robot @openshift-bot