Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-4188: Add docs for proxy_url alertmanager #2582

Merged
merged 3 commits into from
Mar 25, 2025
Merged

MON-4188: Add docs for proxy_url alertmanager #2582

merged 3 commits into from
Mar 25, 2025
+6 −2

Conversation

marioferh
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Sorry, something went wrong.

@marioferh
Add docs for proxy_url alertmanager

Verified

This commit was signed with the committer’s verified signature.
marioferh Mario Fernandez
GPG key ID: DFDFD9BD01601382
Verified
Learn about vigilant mode
Loading
Loading status checks…
a3381df 
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@openshift-ci openshift-ci bot requested review from danielmellado and rexagod March 19, 2025 13:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
eromanova97
eromanova97 reviewed Mar 19, 2025
View reviewed changes
marioferh
marioferh commented Mar 19, 2025
View reviewed changes
Copy link
Contributor Author

@marioferh marioferh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@marioferh @eromanova97
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
648fae0 
ty!

Co-authored-by: Eliska Romanova <eromanov@redhat.com>
@marioferh marioferh changed the title Add docs for proxy_url alertmanager MON-4188: Add docs for proxy_url alertmanager Mar 19, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 19, 2025 •
edited by openshift-ci bot
Loading

@marioferh: This pull request references MON-4188 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sorry, something went wrong.

@marioferh
make generate

Verified

This commit was signed with the committer’s verified signature.
marioferh Mario Fernandez
GPG key ID: DFDFD9BD01601382
Verified
Learn about vigilant mode
Loading
Loading status checks…
3de7bda 
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@marioferh
Copy link
Contributor Author

/retest-required

@marioferh
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

1 similar comment
@marioferh
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

@Tai-RedHat
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 21, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 21, 2025 •
edited by openshift-ci bot
Loading

@marioferh: This pull request references MON-4188 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sorry, something went wrong.

simonpasquier
simonpasquier reviewed Mar 24, 2025
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2025
@eromanova97
Copy link
Contributor

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Mar 24, 2025
@jan--f
Copy link
Contributor

jan--f commented Mar 24, 2025

/lgtm
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 24, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2cc7dad and 2 for PR HEAD 3de7bda in total

@danielmellado
Copy link
Contributor

/lgtm

@danielmellado
Copy link
Contributor

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, jan--f, marioferh, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielmellado,jan--f,marioferh,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 24, 2025 •
edited
Loading

@marioferh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 3de7bda link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2cc7dad and 2 for PR HEAD 3de7bda in total

@openshift-merge-bot openshift-merge-bot bot merged commit 4c301ea into openshift:main Mar 25, 2025
19 of 20 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator
This PR has been included in build cluster-monitoring-operator-container-v4.19.0-202503250607.p0.g4c301ea.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier

@eromanova97 eromanova97

@danielmellado danielmellado

@rexagod rexagod

Assignees

@jan--f jan--f

@danielmellado danielmellado

@simonpasquier simonpasquier

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@marioferh @openshift-ci-robot @Tai-RedHat @eromanova97 @jan--f @danielmellado @openshift-bot @simonpasquier