Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-4189:Updating node-exporter accelerators configmap #2558

Merged
merged 1 commit into from
Mar 20, 2025
Merged

MON-4189:Updating node-exporter accelerators configmap #2558

merged 1 commit into from
Mar 20, 2025
+182 −22

Conversation

yevgeny-shnaidman
Copy link
Contributor

Adding new accelerator for monitoring to the configmap

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Sorry, something went wrong.

@yevgeny-shnaidman
Updating node-exporter accelerators configmap
Loading
Loading status checks…
3781788 
Adding new accelerator for monitoring to the configmap
@yevgeny-shnaidman
Copy link
Contributor Author

/assign @jan--f

@openshift-ci openshift-ci bot requested review from marioferh and slashpai January 15, 2025 09:45
@jan--f
Copy link
Contributor

jan--f commented Jan 15, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025
@yevgeny-shnaidman
Copy link
Contributor Author

/test e2e-aws-ovn-single-node

2 similar comments
@yevgeny-shnaidman
Copy link
Contributor Author

/test e2e-aws-ovn-single-node

@yevgeny-shnaidman
Copy link
Contributor Author

/test e2e-aws-ovn-single-node

@jan--f
Copy link
Contributor

jan--f commented Jan 15, 2025

/test e2e-aws-ovn-single-node

This test is optional, no need to retry. OpenShift is currently in stabilization mode on only accepts critical fixes. This should merge when the branch opens up again.

@yevgeny-shnaidman
Copy link
Contributor Author

/test e2e-aws-ovn-single-node

This test is optional, no need to retry. OpenShift is currently in stabilization mode on only accepts critical fixes. This should merge when the branch opens up again.

Thanks!

@juzhao
Copy link
Contributor

juzhao commented Jan 21, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 21, 2025
@juzhao
Copy link
Contributor

juzhao commented Jan 21, 2025

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025 •
edited
Loading

@yevgeny-shnaidman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 3781788 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yevgeny-shnaidman
Copy link
Contributor Author

/test e2e-aws-ovn

@yevgeny-shnaidman
Copy link
Contributor Author

/test e2e-aws-ovn-techpreview

@yevgeny-shnaidman
Copy link
Contributor Author

yevgeny-shnaidman commented Mar 20, 2025 •
edited by openshift-ci bot
Loading

/retitle MON-4189:Updating node-exporter accelerators configmap

@openshift-ci openshift-ci bot changed the title Updating node-exporter accelerators configmap MON-4189:Updating node-exporter accelerators configmap Mar 20, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 20, 2025 •
edited by openshift-ci bot
Loading

@yevgeny-shnaidman: This pull request references MON-4189 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Adding new accelerator for monitoring to the configmap

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sorry, something went wrong.

@openshift-merge-bot openshift-merge-bot bot merged commit 17769b6 into openshift:main Mar 20, 2025
19 of 20 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator
This PR has been included in build cluster-monitoring-operator-container-v4.19.0-202503201644.p0.g17769b6.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioferh marioferh

@slashpai slashpai

Assignees

@jan--f jan--f

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yevgeny-shnaidman @jan--f @juzhao @openshift-ci-robot @openshift-bot