Skip to content

STOR-2281: Remove csi-snapshot-validation-webhook references #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2025
Merged

STOR-2281: Remove csi-snapshot-validation-webhook references #231

merged 2 commits into from
Mar 21, 2025
+1 −11

Conversation

dfajmon
Copy link
Contributor

@dfajmon dfajmon commented Feb 18, 2025

Remove csi-snapshot-validation-webhook references.

@dfajmon
remove csi-snapshot-validation-webhook image
Loading
Loading status checks…
ff0b5f8
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 18, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 18, 2025 •
edited by openshift-ci bot
Loading

@dfajmon: This pull request references STOR-2281 which is a valid jira issue.

In response to this:

Remove csi-snapshot-validation-webhook references.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gnufied and jsafrane February 18, 2025 14:25
@dfajmon
update readme link
Loading
Loading status checks…
43315ac
@dfajmon
Copy link
Contributor Author

dfajmon commented Feb 18, 2025

/retest

@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2025
@dobsonj
Copy link
Member

dobsonj commented Mar 20, 2025

CI looks good and WEBHOOK_IMAGE is no longer in the operator deployment.

                        "env": [
                            {
                                "name": "OPERAND_IMAGE",
                                "value": "registry.build02.ci.openshift.org/ci-op-nwm3flc9/stable@sha256:25bdb38b4df00e95d685e9b037f0f52ceef6da21730833a4f4df3181c960e3ab"
                            },
                            {
                                "name": "OPERATOR_IMAGE_VERSION",
                                "value": "4.19.0-0.ci.test-2025-02-18-144306-ci-op-nwm3flc9-latest"
                            },
                            {
                                "name": "OPERAND_IMAGE_VERSION",
                                "value": "4.19.0-0.ci.test-2025-02-18-144306-ci-op-nwm3flc9-latest"
                            },
                            {
                                "name": "POD_NAME",
                                "valueFrom": {
                                    "fieldRef": {
                                        "apiVersion": "v1",
                                        "fieldPath": "metadata.name"
                                    }
                                }
                            }
                        ],
                        "image": "registry.build02.ci.openshift.org/ci-op-nwm3flc9/stable@sha256:6c6bfe9f63fc4766d7ecbe799750b3d6fdd6260692533fe4ffa8b0b5ca435ead",
                        "imagePullPolicy": "IfNotPresent",
                        "name": "csi-snapshot-controller-operator",

We need this to merge before openshift/release#61786 and as https://issues.redhat.com//browse/STOR-2281 states the webhook deployment was already removed from this operator.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 20, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 20, 2025 •
edited by openshift-ci bot
Loading

@dfajmon: This pull request references STOR-2281 which is a valid jira issue.

In response to this:

Remove csi-snapshot-validation-webhook references.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b1a1105 and 2 for PR HEAD 43315ac in total

@dobsonj dobsonj mentioned this pull request Mar 20, 2025
Merged
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

@dfajmon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7d1e842 into openshift:main Mar 21, 2025
14 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-csi-snapshot-controller-operator
This PR has been included in build ose-cluster-csi-snapshot-controller-operator-container-v4.19.0-202503210738.p0.g7d1e842.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied

@jsafrane jsafrane

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dfajmon @openshift-ci-robot @jsafrane @dobsonj @openshift-bot