-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0-fr1] [OSPRH-12359] Add dnsnames to telemetry certs #1276
[18.0-fr1] [OSPRH-12359] Add dnsnames to telemetry certs #1276
Conversation
Telemetry-operator tries to use IP addresses to access its dataplane resources, but as a backup it might use hostnames. In order to access Node Exporter and Kepler when they're with hostnames when they're behind TLS, we need to include the hostnames in the certificates.
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/da84a540be524fa6a0f7c4947d28588e ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 42m 58s |
recheck |
This change depends on a change that failed to merge. Change #1277 is needed. |
recheck |
This change depends on a change that failed to merge. Change openstack-k8s-operators/install_yamls#1007 is needed. |
recheck |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8cd44ff
into
openstack-k8s-operators:18.0-fr1
This is an automated cherry-pick of #1237
/assign vyzigold
Depends-On: #1277
Depends-On: openstack-k8s-operators/install_yamls#1007